Refactor/filter strategies to simplify requestfilter decision tree#46
Draft
chrisingenhaag wants to merge 12 commits intomainfrom
Draft
Refactor/filter strategies to simplify requestfilter decision tree#46chrisingenhaag wants to merge 12 commits intomainfrom
chrisingenhaag wants to merge 12 commits intomainfrom
Conversation
Tracing correct spans Correct maven wrapper (not used atm) for future usage Pipeline use java 21 image for docker build switch to logstash format rename gateway spans contextualnames to match current naming trailing slash handling + spotless apply extended ObservationFilter with tests correct RequestFilter handling of mutating + tests tests covering query param hiding test: add docker-compose file for local tracing testing refactor: not recreating objectmapper again and again minor cleanup and renaming + remove duplicat webflux starter dependency Add redis to docker-compose.yml for local test Make lazy redis pubsub init work with context propagation Revert key loading just once Switch to integrated structured logging Ignore x-forwarded-* headers for routing see github ref Enforce statelessness tardis-traceid spamming metrics switch to hardened community jre image + compose description tracing adjustments reg propagation and baggage configurable key location Dockerfile.multi-stage with new community jre image add blockhound to tests to fail on blocking calls Refs: DHEI-17014 spring-cloud/spring-cloud-gateway#3677
replace everytime regex compile and match operations with simple string operations add precompiled regex patterns for query regex patterns in TracingConfiguration
…ot log level info
proper logging for possible dns resolution errors for oauth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RequestFilter is way to complex in decision of which auth headers etc are set downstream. This is an idea of possibly realize this. This is WIP and not working.